Translate variable names for Omega before baseline validation #398
Conversation
TestingAfter struggling to test on Perlmutter, I switched to Chrysalis (with Intel), where I was able to successfully run both the |
|
@cbegeman, could you give this a quick look when you can? I don't think more testing is needed than what I already did. |
cbegeman
left a comment
cbegeman
left a comment
There was a problem hiding this comment.
I really like this change! My only question would be whether we should do the component is ocean check in ocean_io_step's __init__ rather than its methods.
I'll look into that but I think probably so. |
|
There seems to be an easier fix that I'll push in just a second. |
This merge removes unneeded Omega --> MPAS-Ocean dictionaries. It also adds methods for translating a list of variable names, rather than a dataset (useful for valiation variables). This approach will prevent redundant building of the translation maps for each step that needs them and will make the translation available beyond OceanIOSteps
...in OceanIoStep and OceanModelStep
xylar
force-pushed
the
fix-omega-pr-baseline-comparison
branch
from
6380088 to
e221c6e
Compare
|
@xylar Yes, that looks great. |
2 participants
To accomplish this, this PR moves Omega <--> MPAS-Ocean variable translation to the Ocean component class. It removes the unneeded Omega --> MPAS-Ocean dictionaries (we can use the MPAS-Ocean --> Omega dictionaries for both direction). It also adds methods for translating a list of variable names, rather than a dataset (useful for validation variables).
This approach prevents redundant building of the translation maps for each step that needs them and makes the translation available beyond
OceanIOSteps.OceanIOStepshas been updated to use the methods fromOceancomponent for mapping variable and dimension names.Checklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changesFixes #395